Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing text transform from EuiTour. #4839

Merged
merged 2 commits into from
May 28, 2021
Merged

Removing text transform from EuiTour. #4839

merged 2 commits into from
May 28, 2021

Conversation

gjones
Copy link
Contributor

@gjones gjones commented May 28, 2021 •
edited
Loading

Summary

Removing the text-transform: capitalize from the EuiTourStep header title as per Elastic writing guidelines.

Checklist

  • Checked Code Sandbox works for the any docs examples
  • A changelog entry exists and is marked appropriately

Screenshots

Before

Screenshot 2021-05-28 at 13 19 04

After

Screenshot 2021-05-28 at 13 19 26

@gjones gjones requested a review from ryankeairns May 28, 2021 17:24
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4839/

@gjones gjones requested review from cchaos and thompsongl May 28, 2021 18:48
cchaos
cchaos approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gjones gjones merged commit 2ad041c into elastic:master May 28, 2021
@gjones gjones deleted the remove-force-capitalize-from-tour-title branch May 28, 2021 19:09
@thompsongl thompsongl mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

@thompsongl thompsongl Awaiting requested review from thompsongl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gjones @kibanamachine @cchaos