Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v34 #5077

Merged
merged 10 commits into from Aug 25, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 24, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts ^33.0.1 -> ^34.2.0 age adoption passing confidence

Release Notes

elastic/elastic-charts

v34.2.0

Compare Source

Bug Fixes
Features

34.1.1 (2021-08-20)

Bug Fixes

v34.1.1

Compare Source

Bug Fixes

v34.1.0

Compare Source

Bug Fixes
Features

v34.0.0

Compare Source

Code Refactoring
BREAKING CHANGES
  • cartesian: - TextStyle.fontStyle is no longer a string, it's the more specific FontStyle
  • For symmetry, fontStyle in word cloud is also switching from string to FontStyle
  • Certain text configurations included both fill and textColor for the text color; fill got removed, because textColor is part of the public Font type, and because textColor has clearer meaning than fill. Yet, some of the code used the fill property and/or made the fill property also mandatory. So, userland code needs to remove some fill property, and might need to ensure that the correct value is going into textColor
  • getRadians got unpublished
  • No attempt to draw a rect border if there's not enough width/height for at least the specified border width (ie. width/height being at least twice the border width)

33.2.4 (2021-08-16)

Bug Fixes

33.2.3 (2021-08-16)

Bug Fixes

33.2.2 (2021-08-10)

Bug Fixes

33.2.1 (2021-08-09)

Bug Fixes

v33.2.4

Compare Source

Bug Fixes

v33.2.3

Compare Source

Bug Fixes

v33.2.2

Compare Source

Bug Fixes

v33.2.1

Compare Source

Bug Fixes

v33.2.0

Compare Source

Bug Fixes
Features
  • bullet: the tooltip shows up around the drawn part of the chart only (#​1278) (a96cbb4)
  • legend: multiline labels with maxLines option (#​1285) (e0eb096)

v33.1.0

Compare Source

Bug Fixes
Features

33.0.2 (2021-07-20)

Bug Fixes

33.0.1 (2021-07-16)

Bug Fixes

v33.0.2

Compare Source

Bug Fixes

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled due to failing status checks.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 24, 2021
@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@nickofthyme
Copy link
Contributor

Jenkins test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/

@nickofthyme
Copy link
Contributor

Removed this callout since this is now possible on goal charts.

image

Also I noticed that many of the charts are using unnecessarily accurate display values.

Before

image

After

image

@nickofthyme
Copy link
Contributor

Jenkins test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/

@cchaos
Copy link
Contributor

cchaos commented Aug 25, 2021

🎉 Thanks @nickofthyme !!

Removed this callout since this is now possible on goal charts.

Can you point me to the right theme settings to set these colors? I'd like to fix that goal chart example which right now doesn't flip between light and dark mode.

@cchaos
Copy link
Contributor

cchaos commented Aug 25, 2021

Nm, I found it! Having the changelog in the PR summary is really nice.

@cchaos
Copy link
Contributor

cchaos commented Aug 25, 2021

Ah wait sorry, yes, I found the goal chart settings, but this callout was specifically about the bullet chart. It looks like there still is no theme portion for those settings?

@nickofthyme
Copy link
Contributor

Ah wait sorry, yes, I found the goal chart settings, but this callout was specifically about the bullet chart. It looks like there still is no theme portion for those settings?

Bullet, gauge and goal should all share the same theme options via theme.goal. Does that not work?

@cchaos
Copy link
Contributor

cchaos commented Aug 25, 2021

Hmm I'll push up my changes and then can you check I added the theme keys right?

cchaos and others added 2 commits August 25, 2021 10:22
- Bullet chart still doesn’t seem to be getting the new theme colors
@nickofthyme
Copy link
Contributor

Jenkins test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/

@cchaos

This comment has been minimized.

@cchaos
Copy link
Contributor

cchaos commented Aug 25, 2021

Jenkins, test this

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!! I'll check in the browsers once we have PR build. I think this process will keep us in sync way better.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/

@cchaos cchaos enabled auto-merge (squash) August 25, 2021 16:31
@nickofthyme
Copy link
Contributor

Jenkins test this please

@nickofthyme
Copy link
Contributor

Jenkins test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/

@nickofthyme
Copy link
Contributor

Jenkins test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/

@cchaos cchaos merged commit fa14cf4 into master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants