Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiAspectRatio] Remove sass and replace with inline styles #5818

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

snide
Copy link
Contributor

@snide snide commented Apr 19, 2022

Summary

Converts EuiApsectRatio to use the new aspect-ratio css property https://caniuse.com/mdn-css_properties_aspect-ratio

This removed a bit of the css, and since this has no themable elements, it felt best to just convert it completely to inline styles.

Checklist

  • [ ] Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@snide snide marked this pull request as ready for review April 19, 2022 17:53
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5818/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5818/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I checked a lot of our direct uses in our docs in all three browsers. Yay for plain CSS and yay for reducing div count!

If you update from main, I think CI will pass

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5818/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants