Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Enable JSX transform #5849

Closed
wants to merge 7 commits into from

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 27, 2022

Summary

🚧 This doesn't actually solve one of the cases that I'd hoped. Keeping in draft while I evaluate.

  • Code annotations
  • Dev/prod config
  • cloneElement
  • peerDependencies bump

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5849/

@thompsongl
Copy link
Contributor Author

✖ components/datagrid/data_grid.spec.tsx

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5849/

@thompsongl
Copy link
Contributor Author

Closing; will revisit as part of #5540

@thompsongl thompsongl closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants