[EuiPage*_Deprecated] Use @deprecated flag
#6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6194/ |
chandlerprall
approved these changes
Aug 30, 2022
vloth
added a commit
to vloth/eui-cljs
that referenced
this pull request
Nov 16, 2022
Page content was deprecated in favor of a general purpose page template, or page section [1]. Added peerDependencies as required in the version 64.0.0 [2]. [1]: elastic/eui#6194 [2]: https://github.com/elastic/eui/blob/v64.0.0/wiki/consuming.md#installation
vloth
added a commit
to vloth/eui-cljs
that referenced
this pull request
Nov 16, 2022
Page content was deprecated in favor of a general purpose page template, or page section [1]. Added peerDependencies as required in the version 64.0.0 [2]. Fixes elastic#38 [1]: elastic/eui#6194 [2]: https://github.com/elastic/eui/blob/v64.0.0/wiki/consuming.md#installation
haywoood
pushed a commit
to elastic/eui-cljs
that referenced
this pull request
Jan 13, 2023
Page content was deprecated in favor of a general purpose page template, or page section [1]. Added peerDependencies as required in the version 64.0.0 [2]. Fixes #38 [1]: elastic/eui#6194 [2]: https://github.com/elastic/eui/blob/v64.0.0/wiki/consuming.md#installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using the
@deprecatedjsdoc flag will be picked up by supporting IDEs (VSCode, possibly webstorm as well) and add a strikethrough in both import and component usage:This will be relatively useful in encouraging Kibana consumers to switch over from deprecated components sooner rather than later.
Checklist
N/A - technically this is not an actual source-code-affecting change and only affects development 🤔