Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDescriptionListTitle] Misc compressed style fixes #7185

Merged
merged 4 commits into from
Sep 14, 2023
Merged

[EuiDescriptionListTitle] Misc compressed style fixes #7185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e44a951
[EuiDescriptionListTitle] Fix missed override Sass
cee-chen Sep 13, 2023
feeadd3
Delete Sass files
cee-chen Sep 13, 2023
b1b7a09
Fix inline titles being passed a margin-top that does nothing
cee-chen Sep 13, 2023
d97e55f
changelog
cee-chen Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/description_list/__snapshots__/description_list_title.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ exports[`EuiDescriptionListTitle EuiDescriptionListTitle prop variations type co

exports[`EuiDescriptionListTitle EuiDescriptionListTitle prop variations type inline is rendered 1`] = `
<dt
class="euiDescriptionList__title emotion-euiDescriptionList__title-inline-normal-s"
class="euiDescriptionList__title emotion-euiDescriptionList__title-inline-normal"
/>
`;

Expand Down
3 changes: 2 additions & 1 deletion src/components/description_list/description_list_title.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ export const euiDescriptionListTitleStyles = (euiThemeContext: UseEuiTheme) => {
${logicalCSS('padding-horizontal', euiTheme.size.xs)}
`,
compressed: css`
${euiFontSize(euiThemeContext, 'xs')}
font-size: ${euiFontSize(euiThemeContext, 'xs').fontSize};
line-height: ${euiTheme.font.lineHeightMultiplier};
${logicalCSS('padding-vertical', '0')}
${logicalCSS('padding-horizontal', euiTheme.size.xs)}
`,
Expand Down
1 change: 0 additions & 1 deletion src/components/description_list/description_list_title.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export const EuiDescriptionListTitle: FunctionComponent<
conditionalStyles = compressed
? [styles.inlineStyles.compressed]
: [styles.inlineStyles.normal];
conditionalStyles.push(styles[rowGutterSize]);
break;
case 'row':
conditionalStyles.push(styles[rowGutterSize]);
Expand Down
7 changes: 0 additions & 7 deletions src/themes/amsterdam/overrides/_description_list.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/themes/amsterdam/overrides/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
@import 'combo_box';
@import 'data_grid';
@import 'description_list';
@import 'form_control_layout';
@import 'form_control_layout_delimited';
@import 'form_controls';
Expand Down
4 changes: 4 additions & 0 deletions upcoming_changelogs/7185.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed the inline compressed styles of `EuiDescriptionListTitle` to use a taller line-height for readability