Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Reduce CSS browser prefixing to supported browsers only #7272

Merged
merged 23 commits into from
Oct 10, 2023
Merged

[Emotion] Reduce CSS browser prefixing to supported browsers only #7272

merged 23 commits into from
Oct 10, 2023

Commits on Oct 9, 2023

  1. Copy Emotion's existing prefixer logic 

    source: https://github.com/emotion-js/emotion/blob/f3b268f7c52103979402da919c9c0dd3f9e0e189/packages/cache/src/prefixer.js
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bf9a394 View commit details
    Browse the repository at this point in the history

  2. Add typing + minor syntax changes

    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e63d421 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary :/:: selector prefixes 

    - not needed by latest evergreen browsers
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a05e278 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary animation/keyframes prefixes 

    - not needed by evergreen browsers - https://caniuse.com/mdn-css_at-rules_keyframes
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5ce5159 View commit details
    Browse the repository at this point in the history

  5. [organization] move js docblock/export up above 

    - more useful to have devs see this immediately, particularly the comment
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    60b45e5 View commit details
    Browse the repository at this point in the history

  6. Remove flex CSS prefixes 

    - unnecessary for evergreen browsers
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b180c40 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary transform/transition CSS prefixes 

    - https://caniuse.com/?search=transform
- https://caniuse.com/mdn-css_properties_transition
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    843c05b View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary position sticky prefixes 

    - https://caniuse.com/css-sticky
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ef59862 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary writing-mode prefixes 

    - https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode#browser_compatibility
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    29f7a4f View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary columns prefixes 

    - https://caniuse.com/multicolumn
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b9c076d View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary text-related prefixes

    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    012e6d9 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary filter/image related prefixes

    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    20a55d4 View commit details
    Browse the repository at this point in the history

  13. Remove unnecessary inline logical property prefixes 

    - https://caniuse.com/mdn-css_properties_padding-inline-start
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2840969 View commit details
    Browse the repository at this point in the history

  14. Tweak prefixes for sizing values to only stretch values 

    - other values appear to be unnecessary, per linked caniuse docs
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    35b399c View commit details
    Browse the repository at this point in the history

  15. Remove unnecessary extra -moz/-ms prefixes

    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    fb1f2bf View commit details
    Browse the repository at this point in the history

  16. Add more tests + comments for more prefixed CSS 

    + reorder

+ fix `print-color-adjust` property, `color-adjust` does not exist - also who on earth is using this
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4d37898 View commit details
    Browse the repository at this point in the history

  17. Add mask tests 

    https://caniuse.com/css-masks
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8c31cb0 View commit details
    Browse the repository at this point in the history

  18. More granular background-clip prefixing 

    - only 1 value needs it
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e0f7dfa View commit details
    Browse the repository at this point in the history

  19. [docs] Update docs site to use prefix plugin + add documentation

    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d596e52 View commit details
    Browse the repository at this point in the history

  20. Update default EUI provider cache and theme provider to use new prefi… 

    …xer plugin

- this requires creating a new custom vanilla JS `@emotion/css` cache

- NOTE: Other components that use `@emotion/css` (e.g. overlay mask, code block) should NOT use this new util yet, as there's a bug with its auto label behavior
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7e1ed3e View commit details
    Browse the repository at this point in the history

  21. [misc] Fix missing color mode label/name 

    + fix jsdoc typo
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4366d18 View commit details
    Browse the repository at this point in the history

  22. Update downstream EuiThemeProvider snapshots 

    The removed `colorClassName` auto label is due to the difference in how the default `@emotion/css` behaves compared to `@emotion/css/create-instance`
    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3bfaaf0 View commit details
    Browse the repository at this point in the history

  23. changelog

    @cee-chen
    cee-chen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9d4bb78 View commit details
    Browse the repository at this point in the history