[EuiBreadcrumb] Apply new visual design changes #7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Mar 25, 2024
cee-chen
reviewed
Mar 25, 2024
cee-chen
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Thanks for putting this together, @mgadewoll! It looks great. I've left a few small comments for my initial review. Let me know if you have any questions.
There was a problem hiding this comment.
Thanks so much for making those changes, @mgadewoll! I left two small comments after re-reviewing. After these are addressed, I think it's good to go from my perspective.
8 tasks
cee-chen
reviewed
Apr 2, 2024
cee-chen
reviewed
Apr 2, 2024
cee-chen
reviewed
Apr 2, 2024
cee-chen
reviewed
Apr 2, 2024
cee-chen
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Super sorry for the last minute annoying nits/comments, feel free to skip them if you'd rather get this merged! Changes & QA look great to me, although of course feel free to double check me @MichaelMarcialis!
MichaelMarcialis
approved these changes
Apr 2, 2024
- update font-weight and color - add permanent underline to interactive breadcrumbs
- exclude interactive styles being applied to deprecated custom color variant cleanup obsolete EuiText wrapper
…nteractive styles applied
mgadewoll
force-pushed
the
breadcrumb/7384-new-visual-design
branch
from
fcbf0fd
to
ca4c418
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Apr 9, 2024
`v93.5.2` ⏩ `v93.6.0` --- ## [`v93.6.0`](https://github.com/elastic/eui/releases/v93.6.0) - Updated `EuiBreadcrumb` styles to improve visual distinction of clickable breadcrumbs ([#7615](elastic/eui#7615)) **Deprecations** - Deprecated `color` prop on `EuiBreadcrumb` ([#7615](elastic/eui#7615)) **Bug fixes** - Fixed `EuiComboBox` to correctly select full matches within groups via the `Enter` key ([#7658](elastic/eui#7658)) **Accessibility** - Updated `EuiHeaderBreadcrumb` styles to ensure min. required color contrast ([#7643](elastic/eui#7643)) - `EuiSuperSelect` now correctly reads out parent `EuiFormRow` labels to screen readers ([#7650](elastic/eui#7650)) - `EuiSuperSelect` now more closely mimics native `<select>` behavior in its keyboard behavior and navigation ([#7650](elastic/eui#7650)) - `EuiSuperSelect` no longer strands keyboard focus on close ([#7650](elastic/eui#7650)) - `EuiSuperSelect` now correctly allows keyboard navigating past disabled options in the middle of the options list ([#7650](elastic/eui#7650))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7384
This PR updates
EuiBreadcrumbto apply style changes outlined here.euiTheme.font.weight.regular(400)colorof all breadcrumb items tocolors.subduedTexthreforonClick) to havetext-decoration: underlinecolorof valuecolors.textAdditionally this PR deprecates the
colorprop for breadcrumbs. As part of this deprecation the new hover/focus styles are not applied when customcoloris used.before
after
QA
General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)