-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storybook] Add stories for more components (letter T) - Part 1 #7739
Conversation
b80abe2
to
a32a61c
Compare
(otherwise does nothing if children is not an element)
- to match docs example
d4b7d99
to
e2cdd20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this! All my comments below are optional. I pushed up a few small tweaks that I didn't want to make you have to do. Let me know what you think - if you're not a fan, we can discuss reverting!
packages/eui/src/components/tabs/tabbed_content/tabbed_content.tsx
Outdated
Show resolved
Hide resolved
…dren refactor: ensure types for EuiTabbedContent defaultProps
@cee-chen Thanks for the review! The added updates look good to me, thanks for adding them! ❤️ |
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look terrific!! 🚀
Summary
relates to #7484
This PR adds more stories for components with the letter T:
Additionally adds base VRT reference images based on the added stories.
QA
Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/navigation-euitabs-euitabs--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/navigation-euitabs-euitab--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/navigation-euitabbedcontent--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/display-euitext-euitext--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/display-euitext-euitextalign--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/display-euitext-euitextcolor--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/display-euititle--playground
https://eui.elastic.co/pr_7739/storybook/index.html?path=/story/utilities-useeuitextdiff--playground