Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Add stories for more components (letter T) - Part 1 #7739

Merged
merged 13 commits into from May 15, 2024

Conversation

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels May 7, 2024
@mgadewoll mgadewoll marked this pull request as ready for review May 7, 2024 11:28
@mgadewoll mgadewoll requested a review from a team as a code owner May 7, 2024 11:28
(otherwise does nothing if children is not an element)
- to match docs example
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this! All my comments below are optional. I pushed up a few small tweaks that I didn't want to make you have to do. Let me know what you think - if you're not a fan, we can discuss reverting!

@mgadewoll
Copy link
Contributor Author

@cee-chen Thanks for the review! The added updates look good to me, thanks for adding them! ❤️

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look terrific!! 🚀

@mgadewoll mgadewoll merged commit d633f19 into elastic:main May 15, 2024
5 checks passed
@mgadewoll mgadewoll deleted the storybook/7484-stories-t branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants