Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang-crossbuild as base image #2339

Merged
merged 8 commits into from Apr 28, 2023

Conversation

joshdover
Copy link
Member

@joshdover joshdover commented Feb 13, 2023

What is the problem this PR solves?

Use same base image for building Fleet Server as Elastic Agent from https://github.com/elastic/golang-crossbuild

Checklist

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-28T15:42:15.663+0000

  • Duration: 19 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 679
Skipped 1
Total 680

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@joshdover
Copy link
Member Author

@michel-laterman @v1v any recommendations on how to test this to make sure this doesn't break anything?

@v1v
Copy link
Member

v1v commented Feb 13, 2023

Artifacts are uploaded to a Google bucket:

gsutil list -l gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219
   8019194  2023-02-13T16:18:43Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-darwin-aarch64.tar.gz
       171  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-darwin-aarch64.tar.gz.sha512
   8504876  2023-02-13T16:18:43Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-darwin-x86_64.tar.gz
       170  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-darwin-x86_64.tar.gz.sha512
   8047778  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-linux-arm64.tar.gz
       168  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-linux-arm64.tar.gz.sha512
   7690550  2023-02-13T16:18:43Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-linux-x86.tar.gz
       166  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-linux-x86.tar.gz.sha512
   8760745  2023-02-13T16:18:43Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-linux-x86_64.tar.gz
       169  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-linux-x86_64.tar.gz.sha512
   7859618  2023-02-13T16:18:43Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-windows-x86.zip
       165  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-windows-x86.zip.sha512
   8177708  2023-02-13T16:18:43Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-windows-x86_64.zip
       168  2023-02-13T16:18:42Z  gs://fleet-ci-artifacts/fleet-server/commits/68e1662bf74ff3fa0799e8c81f7a4778d6013219/fleet-server-8.8.0-windows-x86_64.zip.sha512

In addition, I've just found the release ran some release-test verification:

I guess you could download those binaries and start the Fleet-Server, though I'm not much familiar with the Fleet Server itself

@joshdover
Copy link
Member Author

@v1v thank you, we will need to check that.

We also need to check if there are any regressions in this change that were solved by the builder image added in #756

@joshdover
Copy link
Member Author

@michel-laterman @jen-huang Can we prioritize this soon? We need to test these artifacts. We may get lucky and the artifiacts may have the same hashes compared to main. If so, I think we could merge this now.

Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; i don't think this should break anything.
Do we want to add a release note for this?

Dockerfile.build Outdated Show resolved Hide resolved
@joshdover joshdover marked this pull request as ready for review April 28, 2023 15:42
@joshdover joshdover requested review from a team as code owners April 28, 2023 15:42
@joshdover joshdover added Team:Fleet Label for the Fleet team v8.9.0 backport-skip Skip notification from the automated backport with mergify labels Apr 28, 2023
@joshdover joshdover enabled auto-merge (squash) April 28, 2023 15:44
@joshdover joshdover merged commit 25d9a9c into elastic:main Apr 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Fleet Label for the Fleet team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants