Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional subscription channel size #3273

Closed

Conversation

michel-laterman
Copy link
Contributor

What is the problem this PR solves?

Daily 10k scale tests seems to still be flakey on the multiple policy change test.
This is meant as another simple solution before we try to add early cancelations to dispatching policy changes.

How does this PR solve the problem?

Add an optional arg when subscribing to a subscription monitor to specify the channel size. Min val of 1 is enforced. Use in policy monitor to allow more buffered changes to be queued as mutex might be help and block other dispatches.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

Add an optional arg when subscribing to a subscription monitor to
specify the channel size. Min val of 1 is enforced. Use in policy
monitor to allow more buffered changes to be queued as mutex might be
help and block other dispatches.
@michel-laterman michel-laterman added enhancement New feature or request Team:Fleet Label for the Fleet team labels Feb 12, 2024
@michel-laterman
Copy link
Contributor Author

buildkite run perf-tests

Copy link

Quality Gate passed Quality Gate passed

The SonarQube Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
88.2% 88.2% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@michel-laterman
Copy link
Contributor Author

the 10k serverless tests succeeded, but one of the pods went into a crashloop; this is not a good approach to resolve the issue.

@michel-laterman michel-laterman deleted the sub-monitor-ch-size branch March 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant