Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline.tests-staging.yaml #3706

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

juliaElastic
Copy link
Contributor

What is the problem this PR solves?

Synthetic monitor max polls variable not taking effect.

// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

Fix quality gate variable, it was renamed, see https://github.com/elastic/serverless-quality-gates/issues/76

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@juliaElastic juliaElastic added the bug Something isn't working label Jul 10, 2024
@juliaElastic juliaElastic self-assigned this Jul 10, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner July 10, 2024 08:46
@juliaElastic juliaElastic enabled auto-merge (squash) July 10, 2024 08:49
@jlind23
Copy link
Contributor

jlind23 commented Jul 10, 2024

@juliaElastic once #3709 (review) is merged you should be able to rerun your tests and get a green CI.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@juliaElastic juliaElastic merged commit 9f93407 into elastic:main Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants