Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow short buffers to be unmarshaled #110

Merged
merged 4 commits into from May 23, 2022
Merged

allow short buffers to be unmarshaled #110

merged 4 commits into from May 23, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 16, 2022

This makes the behaviour match the documentation, and is required for fixing elastic/beats#31616.

@efd6 efd6 added the bug label May 16, 2022
@efd6 efd6 requested a review from andrewkroh May 16, 2022 07:20
@efd6 efd6 self-assigned this May 16, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 16, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-22T23:50:13.951+0000

  • Duration: 2 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 378
Skipped 40
Total 418

@efd6 efd6 requested a review from adriansr May 16, 2022 07:23
@efd6 efd6 added the Team:Security-External Integrations Label for the Security External Integrations team label May 16, 2022
adriansr
adriansr suggested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry

audit.go Show resolved Hide resolved
@efd6 efd6 requested a review from adriansr May 20, 2022 03:36
@efd6
Copy link
Contributor Author

efd6 commented May 20, 2022

/test

@efd6
Copy link
Contributor Author

efd6 commented May 20, 2022

Tests are passing, but are not able to be published.

@adriansr
Copy link
Contributor

/test

1 similar comment
@efd6
Copy link
Contributor Author

efd6 commented May 22, 2022

/test

@efd6
Copy link
Contributor Author

efd6 commented May 22, 2022

There are still some odd actions in the .ci/test.sh script, but I am leaving those; the change from go get to go install fixes the build.

adriansr
adriansr approved these changes May 23, 2022
View reviewed changes
audit.go Show resolved Hide resolved
@efd6 efd6 merged commit 87f0a81 into elastic:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@efd6 efd6

Labels
bug Team:Security-External Integrations Label for the Security External Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efd6 @elasticmachine @adriansr