Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky-test: TestProcesses #179

Closed
andrewkroh opened this issue May 18, 2023 · 1 comment · Fixed by #182
Closed

flaky-test: TestProcesses #179

andrewkroh opened this issue May 18, 2023 · 1 comment · Fixed by #182
Labels
flaky-test Unstable or unreliable test cases.

Comments

@andrewkroh
Copy link
Member

andrewkroh commented May 18, 2023 •
edited
Loading

I think short-lived processes can cause TestProcesses to fail intermittently.

    system_test.go:304: failed to get process info for PID=6387: open /proc/6387/stat: no such file or directory
--- FAIL: TestProcesses (0.01s)

Observed at #175.
@andrewkroh andrewkroh added the flaky-test Unstable or unreliable test cases. label May 18, 2023
@andrewkroh
Copy link
Member Author

I think we need to ignore ENOENT during that test.

andrewkroh added a commit to andrewkroh/go-sysinfo that referenced this issue May 31, 2023
@andrewkroh
system_test.go - Fix flaky TestProcesses
f1f2fae 
If a process terminates while go-sysinfo is collecting info about it
then ENOENT (no such file or directory) can occur. Ignore that while
testing a live system.

Fixes elastic#179
@andrewkroh andrewkroh mentioned this issue May 31, 2023
Merged
andrewkroh added a commit that referenced this issue May 31, 2023
@andrewkroh
system_test.go - Fix flaky TestProcesses (#182)
d4436c2 
If a process terminates while go-sysinfo is collecting info about it
then ENOENT (no such file or directory) can occur. Ignore that while
testing a live system.

Fixes #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Unstable or unreliable test cases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

system_test.go - Fix flaky TestProcesses andrewkroh/go-sysinfo
1 participant
@andrewkroh