Always lowercase FQDN

[ycombinator]

According to https://www.elastic.co/guide/en/ecs/current/ecs-host.html#field-host-name:

[The host.name field] can contain what hostname returns on Unix systems, the fully qualified domain name (FQDN), or a name specified by the user. The recommended value is the lowercase FQDN of the host.

Accordingly, this PR ensures that the FQDN lookup always results in a lowercased FQDN.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-06-01T14:05:54.379+0000

• Duration: 5 min 19 sec

Test stats 🧪

Test	Results
Failed	0
Passed	161
Skipped	2
Total	163

[andrewkroh]

Do you think we should also ensure that the Hostname is normalized to lowercase?

[andrewkroh]

You'll need to add a changelog file as per https://github.com/elastic/go-sysinfo/blob/main/CONTRIBUTING.md.

[ycombinator]

Do you think we should also ensure that the Hostname is normalized to lowercase?

Probably. I'll add the change to this PR.

You'll need to add a changelog file as per https://github.com/elastic/go-sysinfo/blob/main/CONTRIBUTING.md.

Thanks, didn't realize this repo now has a changelog - nice!

[leehinman]

LGTM

[andrewkroh]

There is one more location to update at

go-sysinfo/providers/aix/host_aix_ppc64.go

Line 176 in 577dee5

h.info.Hostname = v

[andrewkroh]

I think it would be helpful to users to indicate in the godocs that the values are lowercased at

go-sysinfo/types/host.go

Line 70 in 6dcfe88

Hostname string `json:"name"` // Hostname

go-sysinfo/types/host.go

Line 29 in 6dcfe88

FQDN() (string, error)