Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetProcessHandleCount to kernel32 #7

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Add GetProcessHandleCount to kernel32 #7

merged 3 commits into from
Aug 31, 2018

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Aug 30, 2018

GetProcessHandleCount retrieves the number of open handles belonging to a process.

https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-getprocesshandlecount

@kvch kvch added the enhancement New feature or request label Aug 30, 2018
@kvch kvch requested a review from andrewkroh August 30, 2018 12:45
@kvch kvch force-pushed the add-get-process-handle-count branch from 45e147f to 1f52602 Compare August 30, 2018 12:55
andrewkroh
andrewkroh requested changes Aug 30, 2018
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add a very basic smoke test to kernel32_test.go?

@kvch kvch merged commit bb1581b into elastic:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kvch @andrewkroh