Parse apmbench results, add ES basicauth #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the benchmark parsing to allow to optionally parse the extra metrics that are published by apmbench. Modified the Elasticsearch request handling slightly to allow us to authenticate using basicauth and also work with versions of the stack `8.0.0+`. Last, created a Go module to allow the project to work with newer Go versions. Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
16 tasks
axw
reviewed
Apr 5, 2022
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
axw
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Thanks for the updates, looks great!
Later on I think it would be great if we could look at removing well known units from the metric names, and instead set them as field metadata for automatically selecting the default formatter in Lens.
|
I wasn't aware that the mappings were now able to specify all of that, but it looks worth looking into. I will open a follow up issue on this repo which we can come back to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the benchmark parsing to allow to optionally parse the extra
metrics that are published by apmbench. Modified the Elasticsearch
request handling slightly to allow us to authenticate using basicauth
and also work with versions of the stack
8.0.0+.Last, created a Go module to allow the project to work with newer Go
versions.
How to test this changes
cat testdata/benchmark-result.txt| go run main.go -es http://localhost:9200 -es-username admin -es-password changeme -tag "apm-server_version=8.1.2,size=4096.gobenchindex with the right mappings, and that theextra_metricsfields are all indexed asfloat.index_all.shfrom https://gist.github.com/marclop/914c5ebcd53b4ba403066cebc39bf644.Related issues
Part or elastic/apm-server#7540