Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong GCS bucket name in documentation #381

Closed
9 tasks done
andrewkroh opened this issue Jan 24, 2024 · 2 comments
Closed
9 tasks done

Wrong GCS bucket name in documentation #381

andrewkroh opened this issue Jan 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Jan 24, 2024

In the docs at https://github.com/elastic/golang-crossbuild/blame/43f2c4205fe38de4fecf61c39df80a9177062388/NPCAP.md#L8 the bucket name for storing npcap is documented as gs://obs-ci-cache/private, but the builds are looking at gs://ingest-buildkite-ci.

Additionally the builds are not failing when the expected binary is not found within GCS. This means that the latest set of images are broken (e.g. docker.elastic.co/observability-ci/golang-crossbuild:1.21.6-npcap-1.79-debian9) because they don't have the npcap oem installer.

Screenshot 2024-01-24 at 17 51 33
@andrewkroh andrewkroh added the bug Something isn't working label Jan 24, 2024
@andrewkroh
Copy link
Member Author

andrewkroh commented Jan 24, 2024

It would be awesome if there were a buildkite job to automate grabbing the latest npcap. I can provide the npcap credentials (they are in Vault).

# Check what the newest release is using Github.
latest_version=$(curl https://api.github.com/repos/nmap/npcap/releases/latest | jq -r .tag_name | sed 's/^v//g')

# Check if we already have the OEM installer in our GCS bucket.
if gcloud storage ls gs://ingest-buildkite-ci/private/npcap-${latest_version}-oem.exe ; then
    echo "Already present."
    exit
else

# Download it into our GCS bucket.
echo "Fetching new npcap installer"
curl -L -O --digest -u "$NPCAP_USER:$NPCAP_USER" "https://npcap.com/oem/dist/npcap-${latest_version}-oem.exe"
gcloud storage cp ./npcap-${version}-oem.exe gs://ingest-buildkite-ci/private/npcap-${latest_version}-oem.exe

# Open a PR to bump the version in `Makefile.common`.

@dliappis
Copy link

dliappis commented Mar 6, 2024

It would be awesome if there were a buildkite job to automate grabbing the latest npcap. I can provide the npcap credentials (they are in Vault).

I added a follow up task in the post BK migration meta issues -> https://github.com/elastic/ingest-dev/issues/2990 so that we don't forget it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants