Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packetbeat] Bump npcap to 1.79 #37733

Merged
merged 2 commits into from Jan 25, 2024

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jan 24, 2024

Proposed commit message

Bump the included npcap installer to version 1.79.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh andrewkroh added enhancement Packetbeat backport-v8.12.0 Automated backport with mergify labels Jan 24, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2024
@andrewkroh
Copy link
Member Author

A backport to 8.12 depends on

@andrewkroh andrewkroh marked this pull request as ready for review January 24, 2024 21:52
@andrewkroh andrewkroh requested a review from a team as a code owner January 24, 2024 21:52
@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-24T21:49:12.495+0000

  • Duration: 40 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 1
Total 18

Steps errors 2

Expand to view the steps failures

x-pack/packetbeat-packaging-linux - mage package
  • Took 8 min 42 sec . View more details here
  • Description: mage package
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice to have the tests pass. Was the builder fix not merge in the parent of this branch?

@andrewkroh
Copy link
Member Author

andrewkroh commented Jan 24, 2024

Broken due to elastic/golang-crossbuild#381 (I put the oem installer exe into the wrong GCS bucket b/c docs were wrong and the builds didn't fail hard when it was missing).

update: The images are fixed now.

@norrietaylor norrietaylor added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Jan 25, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 44 min 17 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh added backport-skip Skip notification from the automated backport with mergify and removed backport-v8.12.0 Automated backport with mergify labels Jan 25, 2024
@andrewkroh andrewkroh merged commit d6bed8d into elastic:main Jan 25, 2024
29 of 31 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Packetbeat Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants