Fix ProcState parsing for process names with parantheses #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the ProcState code that parses /proc/[PID]/stat to allow any characters between the opening and closing parentheses of the comm field. This also improves the error handling in ProcState.Get. Previously errors from `strconv.Atio` were not checked. Improved the test for ProcState to validate all fields. Fix bug in test code that generates fake /proc/pid/stat data. It skipped "19" causing an off by one issue. Fixes elastic#81
|
@immon I opened a PR for this myself because I wanted to do some additional refactoring to the code to improve error handling. |
adriansr
reviewed
Nov 23, 2017
sigar_linux_common.go
Outdated
| // Extract the comm value with is surrounded by parentheses. | ||
| lIdx := bytes.Index(data, []byte("(")) | ||
| rIdx := bytes.LastIndex(data, []byte(")")) | ||
| if lIdx < 0 || rIdx < 0 { |
There was a problem hiding this comment.
Nit: Should return an error also when lIdx >= rIdx || rIdx + 2 >= len(data)
to avoid crashing below.
kvch
approved these changes
Nov 23, 2017
|
This has been updated based on the review feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strconv.Atiowere not checked.Fixes #81