[Metricbeat] Dont generate config if not enabled (#767)

If for daemonset/deployment is not enabled, dont generate useless config YAML.
elastic · Oct 20, 2020 · d8f2b4b · d8f2b4b
1 parent 5918d20
commit d8f2b4b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/metricbeat/templates/configmap.yaml b/metricbeat/templates/configmap.yaml
@@ -16,7 +16,7 @@ data:
 {{- end -}}
 {{- end -}}
 
-{{- if .Values.daemonset.metricbeatConfig }}
+{{- if and .Values.daemonset.enabled .Values.daemonset.metricbeatConfig }}
 ---
 apiVersion: v1
 kind: ConfigMap
@@ -34,7 +34,7 @@ data:
 {{- end -}}
 {{- end -}}
 
-{{- if .Values.deployment.metricbeatConfig }}
+{{- if and .Values.deployment.enabled .Values.deployment.metricbeatConfig }}
 ---
 apiVersion: v1
 kind: ConfigMap

diff --git a/metricbeat/tests/metricbeat_test.py b/metricbeat/tests/metricbeat_test.py
@@ -1257,8 +1257,11 @@ def test_disable_daemonset():
     enabled: false
 """
     r = helm_template(config)
+    cfg = r["configmap"]
 
     assert name not in r.get("daemonset", {})
+    assert name + "-daemonset-config" not in cfg
+    assert name + "-deployment-config" in cfg
 
 
 def test_disable_deployment():
@@ -1267,8 +1270,11 @@ def test_disable_deployment():
     enabled: false
 """
     r = helm_template(config)
+    cfg = r["configmap"]
 
     assert name + "-metrics" not in r.get("deployment", {})
+    assert name + "-daemonset-config" in cfg
+    assert name + "-deployment-config" not in cfg
 
 
 def test_do_not_install_kube_stat_metrics():