[filebeat] fix(template): fullnameOverride if releaseName is "filebeat"

[eyenx]

Signed-off-by: Toni Tauro toni.tauro@adfinis.com

• Chart version not bumped (the versions are all bumped and released at the same time)
• README.md updated with any new values or changes # not needed
• Updated template tests in ${CHART}/tests/*.py # not needed
• Updated integration tests in ${CHART}/examples/*/test/goss.yaml # not needed

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[eyenx]

before:

$ helm template filebeat .  | grep " name: "
  name: filebeat-filebeat
  name: filebeat-filebeat-config
  name: filebeat-filebeat-cluster-role
  name: filebeat-filebeat-cluster-role-binding
  name: filebeat-filebeat-cluster-role
  name: filebeat-filebeat
  name: filebeat-filebeat

after:

$ helm template filebeat .  | grep " name: "   fix/filebeat-fullnameOverride ✔
  name: filebeat
  name: filebeat-daemonset-config
  name: filebeat-cluster-role
  name: filebeat-cluster-role-binding
  name: filebeat-cluster-role
  name: filebeat
  name: filebeat
      name: "filebeat"
      - name: filebeat-config
          name: filebeat-daemonset-config

[jmlrt]

Hi @eyenx,
Thanks for opening this PR.
We'll try to review it soon. Please be patient.

[eyenx]

No hurry

[botelastic]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

[jmlrt]

still valid

[jmlrt]

Change looks good technically, however, I'm still not sure we would want to merge it. Using {{ .Release.Name }}-{{ .Chart.Name }} is a kind of convention that we are using in our charts.

If we are changing it we should change it for all our charts at the same time, but it could break eventually for people writing automation based on the pod names.

[botelastic]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

[botelastic]

This PR has been automatically closed because it has not had recent activity since being marked as stale. Please reopen when work resumes.