Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] fix network policies http additional rules #1111

Merged
merged 2 commits into from Mar 17, 2021
Merged

[elasticsearch] fix network policies http additional rules #1111

merged 2 commits into from Mar 17, 2021

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Mar 17, 2021 •
edited

  • Fix http additional rules to use with NetworkPolicies.
  • Adds some small improvements in network policies tests:
    • update example Makefile to fix commands and use similar structure to other examples Makefiles
    • fix example values file extension
    • use different values for http and transport network policies in python test and example values to catch regressions where same values would be used for both

Fix #1106

@jmlrt
[elasticsearch] fix network policies http additional rules
1063385 
This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106
@jmlrt jmlrt requested a review from a team March 17, 2021 13:06
@jmlrt jmlrt mentioned this pull request Mar 17, 2021
Closed
Conky5
Conky5 previously approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt
[elasticsearch] improve netpol tests
3364342 
This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
@jmlrt jmlrt requested a review from Conky5 March 17, 2021 16:32
Conky5
Conky5 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt added bug Something isn't working need-backport labels Mar 17, 2021
@jmlrt jmlrt merged commit c5e42ed into elastic:master Mar 17, 2021
@jmlrt jmlrt deleted the fix-1106 branch March 17, 2021 17:04
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request May 25, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (elastic#1111
d6c1306 
)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
@jmlrt jmlrt mentioned this pull request May 25, 2021
Merged
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request May 25, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (elastic#1111
501066e 
)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
@jmlrt jmlrt mentioned this pull request May 25, 2021
Merged
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request May 25, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (elastic#1111
3c4c694 
)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
@jmlrt jmlrt mentioned this pull request May 25, 2021
Merged
jmlrt added a commit that referenced this pull request May 28, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111) (#…
64f5174 
…1207)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit that referenced this pull request May 28, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111) (#…
54fde15 
…1208)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit that referenced this pull request May 28, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111) (#…
e5e4907 
…1209)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
@elasticmachine elasticmachine mentioned this pull request Jun 2, 2021
Merged
@elasticmachine elasticmachine mentioned this pull request Jul 8, 2021
Merged
@elasticmachine elasticmachine mentioned this pull request Aug 3, 2021
Merged
@jmlrt jmlrt mentioned this pull request Dec 14, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Conky5 Conky5 Conky5 approved these changes

Assignees
No one assigned
Labels
backported bug Something isn't working elasticsearch v6.8.17 v7.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Policy - Additonnal Rule
2 participants
@jmlrt @Conky5