This repository has been archived by the owner on May 16, 2023. It is now read-only.
[all] Add support to ingress networking.k8s.io/v1 & ingressClassName #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
framsouza
force-pushed
the
master
branch
3 times, most recently
from
6b05d3e
to
ae8f7d0
Compare
jmlrt
suggested changes
Oct 11, 2021
There was a problem hiding this comment.
Thanks for this PR @framsouza, note that most comment I did for apm-server/templates/ingress.yaml are also valid for the other charts
|
Following #1410 merge, we don't need to support anymore K8S 1.18, so we may avoid using |
jmlrt
pushed a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 14, 2021
…lastic#1409) * Adding support to Ingress networking.k8s.io/v1 * Adjusting ES service name * Removing ingress typo & adjusting python test * Adjusting python tests to use the new ingress version * fixing conflict * Adding support to kubernetes ingress v1 & ClassName * Adding reformatted files * fixing conflict * Adding ClassName & Pathtype on ingress settings * Performing syntax adjustments and removing comments
jmlrt
pushed a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 14, 2021
…lastic#1409) * Adding support to Ingress networking.k8s.io/v1 * Adjusting ES service name * Removing ingress typo & adjusting python test * Adjusting python tests to use the new ingress version * fixing conflict * Adding support to kubernetes ingress v1 & ClassName * Adding reformatted files * fixing conflict * Adding ClassName & Pathtype on ingress settings * Performing syntax adjustments and removing comments
This was referenced Dec 14, 2021
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 14, 2021
jmlrt
added a commit
that referenced
this pull request
Dec 14, 2021
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 14, 2021
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 14, 2021
jmlrt
added a commit
that referenced
this pull request
Dec 14, 2021
…1409) (#1478) * Adding support to Ingress networking.k8s.io/v1 * Adjusting ES service name * Removing ingress typo & adjusting python test * Adjusting python tests to use the new ingress version * fixing conflict * Adding support to kubernetes ingress v1 & ClassName * Adding reformatted files * fixing conflict * Adding ClassName & Pathtype on ingress settings * Performing syntax adjustments and removing comments Co-authored-by: framsouza <francismara.souza@elastic.co>
jmlrt
added a commit
that referenced
this pull request
Dec 14, 2021
…1409) (#1479) * Adding support to Ingress networking.k8s.io/v1 * Adjusting ES service name * Removing ingress typo & adjusting python test * Adjusting python tests to use the new ingress version * fixing conflict * Adding support to kubernetes ingress v1 & ClassName * Adding reformatted files * fixing conflict * Adding ClassName & Pathtype on ingress settings * Performing syntax adjustments and removing comments Co-authored-by: framsouza <francismara.souza@elastic.co>
jmlrt
added a commit
that referenced
this pull request
Dec 14, 2021
jmlrt
added a commit
that referenced
this pull request
Dec 14, 2021
Merged
Merged
This was referenced Sep 14, 2022
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to ingress
networking.k8s.io/v1that was added in Kubernetes v1.19.Fix #1381
Fix #1136