This repository has been archived by the owner on May 16, 2023. It is now read-only.
[Kibana] Update kibana service template #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an option to add annotations(s) to service resource. Signed-off-by: natebwangsut <nate.bwangsut@gmail.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
natebwangsut
changed the title
natebwangsut
changed the title
Crazybus
suggested changes
Jun 6, 2019
There was a problem hiding this comment.
Thanks for adding this in!
Could you also add this basic template test into kibana/tests/kibana_test.py
def test_service_annotatations():
config = '''
service:
annotations:
cloud.google.com/load-balancer-type: "Internal"
'''
r = helm_template(config)
s = r['service'][name]['metadata']['annotations']['cloud.google.com/load-balancer-type'] == 'Internal'
|
Any update ? |
Crazybus
previously approved these changes
Jun 7, 2019
|
jenkins test this please |
Crazybus
added a commit
that referenced
this pull request
Jun 7, 2019
Crazybus
reviewed
Jun 7, 2019
|
jenkins test this please |
Crazybus
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: natebwangsut nate.bwangsut@gmail.com
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml