This repository has been archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] do not regenerate certs during upgrade #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit remove the `pre-upgrade` hook for the certificate secret to ensure that the certificate isn't regenerate each time we run the `helm upgrade` command.
|
👋🏻 @framsouza, I discovered this issue while working on #1676. Each time I ran I'm afraid we could also have issues in prod environnements when an Elasticsearch pod is recreated (for example because of a K8S node failure) in a chart release that has already been upgraded, because the new pod could be using a new certificate while the other ones would still be using the old certificate from the first deployment. Do you see some use case where regenerating certs during upgrade is required? |
|
ok to test |
1 similar comment
|
ok to test |
framsouza
approved these changes
Aug 29, 2022
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove the
pre-upgradehook for the certificate secret toensure that the certificate isn't regenerate each time we run the
helm upgradecommand.