This repository has been archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] do not regenerate certs when they already exists #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit update the way we generate the Elasticsearch certs to lookup if the certs secret already exists and reuse the secrets instead of regenerate the certs. This fix the issue when upgrading from a previous version of the chart that doesn't include the certs secret by ensuring that the certs secret is created if it doesn't exists. This method also add more flexibility than charts hooks by ensuring that the certs won't be rotated each time we upgrade the chart. Found in https://stackoverflow.com/a/61715870
|
cc @framsouza for review as this is impacting your changes from #1519. Not sure if there is another way to handle it. |
framsouza
approved these changes
Sep 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit update the way we generate the Elasticsearch certs to lookup
if the certs secret already exists and reuse the secrets instead of regenerate
the certs.
This fix the issue when upgrading from a previous version of the chart
that doesn't include the certs secret by ensuring that the certs secret
is created if it doesn't exists.
This method also add more flexibility than charts hooks by ensuring that
the certs won't be rotated each time we upgrade the chart.
Found in https://stackoverflow.com/a/61715870