Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

raw_input() was removed in Python 3 #195

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 1, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As an FYI there is nothing stopping us from switching things over to python3 besides time. So supporting both is nice but it might be easier to just switchover to python3.

@Crazybus
Copy link
Contributor

Crazybus commented Jul 3, 2019

jenkins test this please

@Crazybus Crazybus merged commit 1ff71b1 into elastic:master Jul 3, 2019
@cclauss cclauss deleted the patch-1 branch July 3, 2019 07:03
@cclauss
Copy link
Contributor Author

cclauss commented Jul 3, 2019

Are the Jenkins tests run on Python 3?

@cclauss
Copy link
Contributor Author

cclauss commented Jul 3, 2019

there is nothing stopping us from switching things over to python3 besides time

https://pythonclock.org

@Crazybus
Copy link
Contributor

Are the Jenkins tests run on Python 3?

They run inside of a docker container defined here:

FROM python:2.7-onbuild
ENV HELM_VERSION=2.14.0
RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v${HELM_VERSION}-linux-amd64.tar.gz && \
tar xfv helm-v${HELM_VERSION}-linux-amd64.tar.gz && \
mv linux-amd64/helm /usr/local/bin/ && \
rm -rf linux-amd64 && \
HOME=/ helm init --client-only && \
chmod 777 -R /.helm

So if you wanted to switch the python testing over to python3 you could do it all in one PR and switch out the image here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants