Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add option to disable sysctlInitContainer #220

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

JorisAndrade
Copy link
Contributor

Following #132 that looked pretty abandoned.
I just fixed the comments of this PR and added an entry to the README.md

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Signed-off-by: Joris Andrade <joris@frontapp.com>
elasticsearch/README.md Outdated Show resolved Hide resolved
elasticsearch/tests/elasticsearch_test.py Outdated Show resolved Hide resolved
elasticsearch/README.md Outdated Show resolved Hide resolved
@JorisAndrade JorisAndrade force-pushed the joris/optional_privileged_true branch 2 times, most recently from 3a3327d to a86782b Compare July 11, 2019 13:04
Signed-off-by: Joris Andrade <joris@frontapp.com>
@JorisAndrade JorisAndrade force-pushed the joris/optional_privileged_true branch from a86782b to 2188b4a Compare July 11, 2019 13:05
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for picking this up and adding in the tests ⭐️

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus Crazybus merged commit 5d8c687 into elastic:master Jul 11, 2019
@JorisAndrade
Copy link
Contributor Author

LGTM! Thanks a lot for picking this up and adding in the tests ⭐️

My pleasure, won't hesitate to create other PRs if we are stuck on something :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants