This repository has been archived by the owner on May 16, 2023. It is now read-only.
[kibana] Explicitly test for a 200 for readinessProbe #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one fails as expected now!
|
If authentication wasn't configured correctly the Kibana readinessProbe would still pass since `curl --fail` doesn't consider a redirect to be a failure. If authentication fails Kibana would redirect you back to the login page so this readinessProbe always passed for security clusters. The tests are going to fail until #272 is merged and this PR has been rebased on top of it.
|
Rebased on master now that #272 has been merged in. Lets see if the tests now pass properly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If authentication wasn't configured correctly the Kibana readinessProbe
would still pass since
curl --faildoesn't consider a redirect to be afailure. If authentication fails Kibana would redirect you back to the
login page so this readinessProbe always passed for security clusters.
The tests are going to fail until #272 is merged and this PR has been
rebased on top of it.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml