This repository has been archived by the owner on May 16, 2023. It is now read-only.
[Issue #267] Support fullnameOverride in kibana, filebeat, metricbeat… #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Please accept this PR. The
🤔 |
|
@tusciucalecs, thanks for the PR, can you rebase it on master to resolve conflicts? |
# Conflicts: # metricbeat/tests/metricbeat_test.py
|
@jmlrt Done. |
|
jenkins test this please |
dmccaffery
added a commit
to deavon-and-tiffany/helm-charts
that referenced
this pull request
Apr 20, 2020
NOTES: The kibana chart did not respect the `fullnameOverride` in the template helpers despite including fullNameOverride in the values.yaml. This resolves that issue. See: elastic/helm-charts#330 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… charts
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml