Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add support for envfrom #369

Merged
merged 10 commits into from
Dec 27, 2019
Merged

Add support for envfrom #369

merged 10 commits into from
Dec 27, 2019

Conversation

jmymy
Copy link
Contributor

@jmymy jmymy commented Nov 13, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

envFrom: Configure all key-value pairs in a ConfigMap as container environment variables

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmymy jmymy marked this pull request as ready for review November 13, 2019 12:09
@jmlrt jmlrt added the enhancement New feature or request label Nov 21, 2019
@jmlrt
Copy link
Member

jmlrt commented Dec 27, 2019

jenkins test this please

metricbeat/templates/deployment.yaml Show resolved Hide resolved
metricbeat/templates/daemonset.yaml Show resolved Hide resolved
@jmymy
Copy link
Contributor Author

jmymy commented Dec 27, 2019

jenkins test this please

eeek. Sorry about that. updated.

@jmlrt
Copy link
Member

jmlrt commented Dec 27, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt jmlrt merged commit 3490379 into elastic:master Dec 27, 2019
@jmymy jmymy deleted the add-support-for-envfrom branch December 27, 2019 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants