Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

adding securityContext/PSP support for Kibana #38

Merged
merged 2 commits into from
Jan 23, 2019
Merged

adding securityContext/PSP support for Kibana #38

merged 2 commits into from
Jan 23, 2019

Conversation

mszumilak
Copy link
Contributor

When Pod Security Policy is in use it might be required to specify serviceAccount as well as runAsUser and fsGroups for starting the pod. Unless requested parameters are not specified pod cannot start.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity could you tell me why you need to be able to set these options? I'm mostly just curious since it is not something I have needed to do when running Kibana myself. And maybe this is something that could better be done by default if there is a more secure way to run Kibana in Kubernetes.

Apart from the requested changes I left inline there are few other missing pieces before this is mergeable.

  1. Update the readme with the two new options you have added
  2. Add a basic templating test to make sure that the templating rules work as expected and don't get broken by future changes.
  3. Seems like you still need to sign the CLA agreement before I can accept any of these changes.

I can help you out if needed for number 2. I realise that we don't yet have a developer guide (you are the first contributor yay!). So I'll work on making sure that these steps are included as part of the readme and the pull request template.

kibana/values.yaml Outdated Show resolved Hide resolved
kibana/templates/deployment.yaml Outdated Show resolved Hide resolved
kibana/values.yaml Outdated Show resolved Hide resolved
@mszumilak
Copy link
Contributor Author

Out of curiosity could you tell me why you need to be able to set these options? I'm mostly just curious since it is not something I have needed to do when running Kibana myself. And maybe this is something that could better be done by default if there is a more secure way to run Kibana in Kubernetes.

I have several users in my cluster with special privileges. I want to enforce using the specific, unprivileged user for running services that does not require special permissions.

Apart from the requested changes I left inline there are few other missing pieces before this is mergeable.

1. Update the [readme](https://github.com/elastic/helm-charts/blob/master/kibana/README.md) with the two new options you have added

Done

2. Add a [basic templating test](https://github.com/elastic/helm-charts/blob/master/kibana/tests/kibana_test.py) to make sure that the templating rules work as expected and don't get broken by future changes.

Some help might be required here as I don't fully understand the script.

3. Seems like you still need to sign the [CLA agreement](https://www.elastic.co/contributor-agreement) before I can accept any of these changes.

Done

I can help you out if needed for number 2. I realise that we don't yet have a developer guide (you are the first contributor yay!). So I'll work on making sure that these steps are included as part of the readme and the pull request template.

👍

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

Thank you so much for adding this in and for explaining what the use case is!

I'll add in the template testing in a separate PR and link it from here to show you how it looks.

@Crazybus Crazybus merged commit 3bb5b33 into elastic:master Jan 23, 2019
Crazybus added a commit that referenced this pull request Jan 23, 2019
@Crazybus
Copy link
Contributor

@mszumilak Here are the tests that I added #44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants