Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add extraContainers and extraInitContainers for all charts #473

Merged
merged 11 commits into from
Feb 10, 2020

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Feb 6, 2020

Should fix #327

@jmlrt jmlrt added the enhancement New feature or request label Feb 6, 2020
@jmlrt
Copy link
Member Author

jmlrt commented Feb 6, 2020

jenkins test this please

1 similar comment
@jmlrt
Copy link
Member Author

jmlrt commented Feb 6, 2020

jenkins test this please

@jmlrt jmlrt marked this pull request as ready for review February 6, 2020 19:14
@jmlrt jmlrt requested a review from a team February 6, 2020 19:15
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#327 also mentions porting authProxyPort for kibana but it looks like httpPort could be used, is that right?

@jmlrt
Copy link
Member Author

jmlrt commented Feb 10, 2020

#327 also mentions porting authProxyPort for kibana but it looks like httpPort could be used, is that right?

Yes I think httpPort should be used for that.

@jmlrt jmlrt merged commit ccb1067 into elastic:master Feb 10, 2020
@jmlrt jmlrt deleted the extra-containers branch February 10, 2020 06:41
@willemm
Copy link

willemm commented Feb 10, 2020

I posted the mention about authProxyPort needing to be ported, and I still believe it should be.
After all, if you use any kind of proxy as sidecar of any container, the service.yaml will need to be pointed to the port of the proxy, whereas the main container itself will be listening on a different port. As it is now, both are configured with httpPort which would never work. (Well, actually it will work, it will just bypass the proxy entirely, which is not what you want).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support extraContainers (from stable/kibana chart)
3 participants