This repository has been archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] update readiness probe endpoint #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR update readiness probe endpoint to check only `/` endpoint instead of `/_cluster/health?timeout=0s` when Elasticsearch is already running. This revert to initial config which was changed in elastic#380 with the exception that 503 HTTP code is accepted for 6.x (see elastic/elasticsearch#8902 for more details about why 503 is OK on Elasticsearch 6.x).
Crazybus
suggested changes
Apr 21, 2020
Co-Authored-By: Michael Russell <Crazybus@users.noreply.github.com>
Co-Authored-By: Michael Russell <Crazybus@users.noreply.github.com>
jmlrt
added a commit
that referenced
this pull request
Apr 21, 2020
[elasticsearch] update readiness probe endpoint
This was referenced Apr 21, 2020
fatmcgav
pushed a commit
to fatmcgav/helm-charts
that referenced
this pull request
May 20, 2020
The `readinessProbe` was updated in elastic#586, however this appears to have introduced a bug which can cause the pod to report as ready before it actually is, due to a lack of quoting around the URL query params, combined with the use of '&'. This commit reworks the `readinessProbe` to correctly quote things. Reintroduced the `http` function, and added support for passing `args` in addition to the `path`. Also borrowed the `set --` pattern from the Kibana chart.
4 tasks
fatmcgav
pushed a commit
to fatmcgav/helm-charts
that referenced
this pull request
May 20, 2020
The `readinessProbe` was updated in elastic#586, however this appears to have introduced a bug which can cause the pod to report as ready before it actually is, due to a lack of quoting around the URL query params, combined with the use of '&'. This commit reworks the `readinessProbe` to correctly quote things. Reintroduced the `http` function, and added support for passing `args` in addition to the `path`. Also borrowed the `set --` pattern from the Kibana chart.
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates readiness probe endpoint to check only
/endpoint instead of/_cluster/health?timeout=0swhen Elasticsearch is already running.This revert to initial config which was changed in #380 with the exception that 503 HTTP code is accepted for 6.x (see elastic/elasticsearch#8902 for more details about why 503 is OK on Elasticsearch 6.x).
Fix #553
README.md updated with any new values or changes${CHART}/tests/*.pyUpdated integration tests in${CHART}/examples/*/test/goss.yaml