This repository has been archived by the owner on May 16, 2023. It is now read-only.
issue-60: Add a configurable health status to the readinessProbe command #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Crazybus
suggested changes
Feb 14, 2019
elasticsearch/values.yaml
Outdated
| @@ -118,6 +118,9 @@ readinessProbe: | |||
| successThreshold: 3 | |||
| timeoutSeconds: 5 | |||
|
|
|||
| # https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-health.html#request-params wait_for_status | |||
| minClusterHealthStatus: green | |||
There was a problem hiding this comment.
There are so many custom paramters here that people might want to change other than wait_for_status. How about making this more generic and having it be something like:
clusterHealthCheckParams: wait_for_status=green&timeout=1s
This is going to make this a lot more maintainable if users want to modify the timeout...or add other settings, or if a feature release of Elasticsearch changes the parameters.
There was a problem hiding this comment.
I've updated to that format.
Crazybus
approved these changes
Feb 15, 2019
|
jenkins test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.