Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[filebeat] introduce dnsConfig values for the containers #659

Merged
merged 2 commits into from Oct 5, 2020

Conversation

orong-pp
Copy link
Contributor

Signed-off-by: Oron Gola oron.gola@perception-point.io

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 11, 2020

💚 CLA has been signed

Signed-off-by: Oron Gola <oron.gola@perception-point.io>
@orong-pp
Copy link
Contributor Author

cla/check

@orong-pp
Copy link
Contributor Author

hi
@jmlrt @Crazybus please review

@orong-pp
Copy link
Contributor Author

some details:

the issue:
when kubernetes runs a dns query in one of its pods, it first tries to look for the record in its internal namespaces. it can take 4-5 queries that search different options before we actually get to the final answer
in case we query an external website like spot.io we get 4-5 times more queries than we actually need and this puts unwanted load on coredns pods.

the details for this are all explained here
https://dev.to/mrkaran/dns-lookups-in-kubernetes-5cm1

solution:
so to deal with this issue one can define the ndots dns configuration option
the default is 5 and it means that only urls with 5 or more dots (.) in it will be queried directly from external dns and not go through 4 redundant dns queries

to set the ndots config option lower I added this pull request and made it possible to control this value and set it lower, so that all queries are direct and no internal search is made

dnsConfig documentation:
this is how dnsConfig should be configured according to kubernetes docs
https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/

@orong-pp
Copy link
Contributor Author

I have now signed the CLA

@jmlrt
Copy link
Member

jmlrt commented Jun 29, 2020

jenkins test this please

@botelastic
Copy link

botelastic bot commented Sep 27, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@jmlrt
Copy link
Member

jmlrt commented Sep 28, 2020

jenkins test this please

@botelastic botelastic bot removed the triage/stale label Sep 28, 2020
jmlrt
jmlrt previously approved these changes Oct 2, 2020
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴, just a suggestion about adding a commented example in values.yaml.

filebeat/values.yaml Show resolved Hide resolved
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@orong-pp
Copy link
Contributor Author

orong-pp commented Oct 5, 2020

jenkins test this please

@orong-pp
Copy link
Contributor Author

orong-pp commented Oct 5, 2020

@jmlrt @Crazybus please review

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Oct 5, 2020

jenkins test this please

@jmlrt jmlrt merged commit 205574a into elastic:master Oct 5, 2020
jmlrt added a commit that referenced this pull request Oct 5, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit that referenced this pull request Oct 5, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit that referenced this pull request Oct 5, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@jmlrt
Copy link
Member

jmlrt commented Oct 5, 2020

backported to 6.8, 7.9 and 7.x branches

@nkammah nkammah mentioned this pull request Oct 19, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants