-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for adding these in :)
Could you also please adding the following:
As another note it also seems like you still need to sign the CLA. |
a3fb3be
to
29228e7
Compare
b8e9cd4
to
dcdd3f2
Compare
All done. I'm waiting for my company approve the CLA on my side. |
I signed the CLA, but the merging is still blocked. |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding in the docs and testing 🥇 This is great!
Np... I'm glad to contribute. :) |
I added
extraVolumes
,extraVolumesMounts
,extraInitContainers
andpersistence.annotations
to the helm chart.The
extraInitContainers
is useful in a situation that you want to add an init-container to get the data from a backup copy for example. You can mount the volume from thevolumeClaimTemplate
, and copy the data there.The
extraVolumes
,extraVolumesMounts
can be used to mount the logs folder in a particular volume, and use a sidecar container likefluentd
to send the logs elsewhere.The persistence annotations is a good addition for clusters that don't support the
storageClassName
yet.