Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

support tpl in logstashConfig, logstashPipeline and kibanaConfig #717

Merged
merged 3 commits into from Oct 2, 2020
Merged

support tpl in logstashConfig, logstashPipeline and kibanaConfig #717

merged 3 commits into from Oct 2, 2020

Conversation

qqshfox
Copy link
Contributor

@qqshfox qqshfox commented Jul 9, 2020 •
edited

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fixes #630

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@qqshfox qqshfox marked this pull request as ready for review July 9, 2020 04:11
@qqshfox qqshfox changed the title [logstash] support tpl in logstashConfig [logstash] support tpl in logstashConfig and logstashPipeline Jul 9, 2020
@qqshfox qqshfox changed the title [logstash] support tpl in logstashConfig and logstashPipeline support tpl in logstashConfig, logstashPipeline and kibanaConfig Jul 9, 2020
@jmlrt jmlrt added enhancement New feature or request kibana logstash labels Jul 13, 2020
@jmlrt
Copy link
Member

jmlrt commented Oct 2, 2020

jenkins test this please

jmlrt
jmlrt approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt merged commit 5ad9a67 into elastic:master Oct 2, 2020
jmlrt pushed a commit that referenced this pull request Oct 2, 2020
@qqshfox @jmlrt
support tpl in logstashConfig, logstashPipeline and kibanaConfig (#717)
534d2c0
jmlrt pushed a commit that referenced this pull request Oct 2, 2020
@qqshfox @jmlrt
support tpl in logstashConfig, logstashPipeline and kibanaConfig (#717)
45c054e
jmlrt pushed a commit that referenced this pull request Oct 2, 2020
@qqshfox @jmlrt
support tpl in logstashConfig, logstashPipeline and kibanaConfig (#717)
9cba558
@jmlrt
Copy link
Member

jmlrt commented Oct 2, 2020

backported to 6.8, 7.9 and 7.x branches

@nkammah nkammah mentioned this pull request Oct 19, 2020
Closed
This was referenced Oct 21, 2020
Closed
Merged
Merged
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
@elasticmachine elasticmachine mentioned this pull request Nov 20, 2020
Closed
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
Closed
@elasticmachine elasticmachine mentioned this pull request Nov 23, 2020
Merged
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
@jmlrt jmlrt mentioned this pull request May 25, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmlrt jmlrt jmlrt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request kibana logstash v6.8.13 v7.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utilize the tpl function for logstashConfig and logstashPipeline
3 participants
@qqshfox @elasticmachine @jmlrt