Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Added ingress support to the logstash chart #793

Merged
merged 4 commits into from Oct 16, 2020
Merged

Conversation

jnbelo
Copy link
Contributor

@jnbelo jnbelo commented Aug 20, 2020

Added an ingress template to the logstash chart in order to enable external usage of the http input plugin as well as exposing other http ports. Closes #453 .

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

ebuildy
ebuildy previously approved these changes Oct 9, 2020
@ebuildy
Copy link
Contributor

ebuildy commented Oct 9, 2020

Excellent work!

@jmlrt
Copy link
Member

jmlrt commented Oct 14, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jnbelo,
Thank you for submitting this PR 👍.
Some changes are required to make tests pass.
Otherwise the rest is LGTM.

logstash/values.yaml Outdated Show resolved Hide resolved
logstash/templates/ingress.yaml Outdated Show resolved Hide resolved
logstash/tests/logstash_test.py Show resolved Hide resolved
@jnbelo
Copy link
Contributor Author

jnbelo commented Oct 14, 2020

@ebuildy @jmlrt Thanks for the review! The comments were addressed.

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Oct 16, 2020

jenkins test this please

@jmlrt jmlrt merged commit e4ab721 into elastic:master Oct 16, 2020
@jmlrt
Copy link
Member

jmlrt commented Oct 16, 2020

backported to 6.8, 7.9 and 7.x branches

@nkammah nkammah mentioned this pull request Oct 19, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
@jmlrt jmlrt mentioned this pull request Nov 17, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress support in Logstash
4 participants