This repository has been archived by the owner on May 16, 2023. It is now read-only.
[logstash] Add support to use pattern files #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
tuananhnguyen-ct
force-pushed
the
logstash-add-pattern-support
branch
from
16df72d
to
b5e09f1
Compare
|
@jmlrt can I have a review here please? Thank you. |
|
Hi @tuananhnguyen-ct, |
|
jenkins test this please |
ebuildy
previously approved these changes
Dec 10, 2020
|
@jmlrt please review, the test has passed. Thanks a lot. |
jmlrt
suggested changes
Feb 3, 2021
There was a problem hiding this comment.
Hi @tuananhnguyen-ct, this looks mostly good outside of the copy/paste error in the README.
I'll also try to get someone else with better knowledge of Logstash pattern files than me.
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
|
jenkins test this please |
|
jenkins test this please |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
that referenced
this pull request
Feb 23, 2021
jmlrt
added a commit
that referenced
this pull request
Feb 23, 2021
jmlrt
added a commit
that referenced
this pull request
Feb 23, 2021
This was referenced Mar 23, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlFixes #685, as we don't want to manage the pattern via a configmap externally.
To use the pattern, add
patterns_dir => "/usr/share/logstash/patterns"to your filter.