Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit AWS categories #1342

Closed
kaiyan-sheng opened this issue Jul 21, 2021 · 3 comments · Fixed by #1357
Closed

Revisit AWS categories #1342

kaiyan-sheng opened this issue Jul 21, 2021 · 3 comments · Fixed by #1357
Assignees

Comments

@kaiyan-sheng
Copy link
Contributor

AWS package at the package level has 4 category tags: aws, cloud, network, and security. Inside the AWS package, there are multiple policy templates and each policy template can also have its own category tags. For example: DynamoDB has a database category tag. With how package-registry works, the individual policy template also inherits category tags from the package level. Therefore for all policy templates in the AWS package, they are all by default in aws, cloud, network, and security categories.

My proposal is to only keep aws and cloud for the AWS package level categories and then add the security category tag to the policy template level category instead.

@kaiyan-sheng
Copy link
Contributor Author

@exekias @andrewkroh WDYT?

@andrewkroh
Copy link
Member

SGTM

@exekias
Copy link

exekias commented Jul 22, 2021

👍 thanks for taking this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants