Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Log Integration] Add tags & processors to Custom Log datastreams #3432

Closed
nimarezainia opened this issue May 25, 2022 · 6 comments · Fixed by #4568
Closed

[Custom Log Integration] Add tags & processors to Custom Log datastreams #3432

nimarezainia opened this issue May 25, 2022 · 6 comments · Fixed by #4568
Assignees
Labels
8.6-candidate estimation:Day Task that represents a day of work. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@nimarezainia
Copy link
Contributor

Background:

As we strive to make Elastic Agent a replacement for the beats, there are some global fields, generally applied on an input datastream, which need to also be available in our integrations. Currently there’s little to no consistency between these integrations, causing a lot of frustration amongst our users.

For more details please refer to: https://github.com/elastic/ingest-dev/issues/995

[fyi @akshay-saraswat ]

@nimarezainia nimarezainia added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 29, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@fearful-symmetry
Copy link
Contributor

@nimarezainia I'm a tad confused by the scope of this. Is this issue for adding a tags and processors field to all integrations? Just a certain subset of logging integrations?

@faec
Copy link

faec commented Oct 24, 2022

[drive-by as I review sprint status] This task looks underspecified -- the design doc linked through the meta issue isn't finalized, and it's unclear what the technical deliverables for this specific issue are, so I don't think "estimation:Day" is a realistic tag.

@nimarezainia
Copy link
Contributor Author

@fearful-symmetry this is just about adding tags and processors to the "Custom Log" integration. this was done for the system integration also: #2865 (comment)

@kpollich in context of elastic/elastic-package#949 - how should we be pursuing this?

@kpollich
Copy link
Member

@nimarezainia It would be best to follow suit with #2865 here and add tags + processors to the Custom Logs integration.

Regarding elastic/elastic-package#949, let's not let this block any work in the short term. We can discuss a path forward and what the priority looks like for managing these fields in a global way elsewhere.

@fearful-symmetry
Copy link
Contributor

@nimarezainia it looks like the main codeowners for that don't work here anymore, so I can probably just add it for this one. In the future if we want to add this to more integrations it should probably be done by the code owners of the given integrations, since the .yml.hbs files are so fragile and CI tends to not catch basic errors, so someone with knowledge of a given integration would have an easier time manually testing in-depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6-candidate estimation:Day Task that represents a day of work. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants