cisco_{asa,ftd}: harmonise pipelines #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
efd6
force-pushed
the
2116-cisco_asa_ftd
branch
from
7e2c254
to
44243a4
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
292.91 | 244.56 | -48.35 (-16.51%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This brings the cisco_asa and cisco_ftd ingest pipelines more into agreement though parts dealing with ECS categorisation remain distinct. The changes in cisco_asa do not affect test outcomes and are for the most part cosmetic to reduce diff noise in future changes. It does add the malware event kind classification that exists in cisco_ftd. The changes in cisco_ftd fix incorrect handling of: - network.inner/cisco.ftd.tunnel_type fields - 305012 events. And add the network.community_id field to events.
efd6
force-pushed
the
2116-cisco_asa_ftd
branch
from
44243a4
to
25ed220
Compare
taylor-swanson
approved these changes
Oct 12, 2022
|
@taylor-swanson Yeah, I was following the existing naming convention. I'm happy to change it if you would like. |
|
If you think of a good, short descriptive file name, go for it, otherwise I'm fine with it as-is. |
|
I'll leave it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This brings the cisco_asa and cisco_ftd ingest pipelines more into agreement though parts dealing with ECS categorisation remain distinct.
The changes in cisco_asa do not affect test outcomes and are for the most part cosmetic to reduce diff noise in future changes. It does add the malware event kind classification that exists in cisco_ftd.
The changes in cisco_ftd fix incorrect handling of:
And add the network.community_id field to events.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots