Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset tags to security integrations #7483

Closed
narph opened this issue Aug 22, 2023 · 6 comments
Closed

Add asset tags to security integrations #7483

narph opened this issue Aug 22, 2023 · 6 comments
Assignees

Comments

@narph
Copy link
Contributor

narph commented Aug 22, 2023

With the merge of elastic/kibana#162643 we are now able to add automatic tagging to our integration packages.

Currently there are 3 tasks that needs to be performed.

  1. Try adding it to an integration, and ensure that the integration still are able to be installed (though without tags) on older versions like 8.8 or 8.7, then once more on 8.10 to confirm the correct tag is added.
  2. Once confirmed, we should use some sort of tooling to add a few specific things to integrations that we own all datastreams for:
    Bump format_version to 2.10.0+
    Add a tags.yml in the kibana folder of the integration, and fill it with:
 - text: Security Solution
  asset_types:
    - dashboard
    - search

This should tag all our asset types needed to view them, we can check by going to the Security Solution UI, and click "Dashboards".
3. Once step 2 is performed, we can manually add the tags.yml to the integration packages with multiple owners, but here we have to specify the dashboard ID of the assets we want to tag:

- text: Security Solution
  asset_ids:
    - id1
    - id2
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr
Copy link
Contributor

marc-gr commented Aug 23, 2023

  1. Try adding it to an integration, and ensure that the integration still are able to be installed (though without tags) on older versions like 8.8 or 8.7, then once more on 8.10 to confirm the correct tag is added.

The minimum kibana version for this to be supported is 8.10.0, including validation, so for any package we want to include the tags.yml, we will need to bump kibana version to 8.10.0 along the way, otherwise the package can't be built with an error like

Error: building package failed: invalid content found in built zip package: found 1 validation error:
   1. conditions.kibana.version must be ^8.10.0 or greater to include saved object tags file: kibana/tags.yml

So they won't be able to be installed in < 8.10 with the file present.

Edit: unless we change the validation criteria

@marc-gr
Copy link
Contributor

marc-gr commented Aug 23, 2023

I created a PR to relax that validation and prevent forcing to bump kibana version on all packages elastic/package-spec#577

@ebeahan
Copy link
Member

ebeahan commented Oct 30, 2023

@marc-gr any more work that needs to happen around tagging here?

@marc-gr
Copy link
Contributor

marc-gr commented Oct 31, 2023

@marc-gr any more work that needs to happen around tagging here?

Only package missing is windows, it is pending to solve the same issue mentioned here so it can be upgraded to spec v3. Any other work is done related to this.

@ebeahan
Copy link
Member

ebeahan commented Dec 7, 2023

Filed a separate issues to continue tracking the windows work, which includes setting the asset tags: #8677.

Closing this meta issue.

@ebeahan ebeahan closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants