Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] Add tags.yml file and upgrade to package spec 3.0 #7955

Merged
merged 13 commits into from Oct 2, 2023
Merged

[aws] Add tags.yml file and upgrade to package spec 3.0 #7955

merged 13 commits into from Oct 2, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 25, 2023 •
edited

What does this PR do?

Add tags.yml file so that integration's dashboards and saved searches are tagged with "Security Solution" and displayed in the Security Solution UI.

As part of migrating to package spec 3.0.0 it removed duplicated, invalid field definitions, and invalid release properties.

Add missing dashboard filters.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-02T07:01:00.989+0000

  • Duration: 55 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr marc-gr marked this pull request as ready for review September 25, 2023 08:37
@marc-gr marc-gr requested review from a team as code owners September 25, 2023 08:37
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -2.125
Classes 94.444% (17/18) 👎 -2.125
Methods 86.047% (259/301) 👎 -6.026
Lines 86.075% (7566/8790) 👎 -1.907
Conditionals 100.0% (0/0) 💚

@marc-gr marc-gr force-pushed the feat/aws-security-tags branch 2 times, most recently from a6d3db8 to c686a83 Compare September 25, 2023 11:58
@marc-gr marc-gr requested a review from a team as a code owner September 25, 2023 11:58
@marc-gr marc-gr force-pushed the feat/aws-security-tags branch 2 times, most recently from 466b0b5 to a6a424e Compare September 26, 2023 08:31
@marc-gr marc-gr marked this pull request as draft September 26, 2023 09:18
@marc-gr marc-gr changed the title Add tags.yml file so that integration's dashboards and saved searches are tagged with 'Security Solution' Add tags.yml file and upgrade to package spec 3.0 Sep 27, 2023
@marc-gr marc-gr marked this pull request as ready for review September 27, 2023 13:58
@marc-gr marc-gr changed the title Add tags.yml file and upgrade to package spec 3.0 [aws] Add tags.yml file and upgrade to package spec 3.0 Sep 28, 2023
kcreddy
kcreddy approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just curios how missing dashboard filters is fixed? Did you run a script or had to apply the filters manually?

@kaiyan-sheng
Copy link
Contributor

@tommyers-elastic I assume this PR will replace #7958 then?

tommyers-elastic
tommyers-elastic approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i think we could still simplify that dashboard filter to make it more maintainable, but not a blocker. thanks!

@marc-gr marc-gr merged commit 29cadc0 into elastic:main Oct 2, 2023
4 checks passed
@marc-gr marc-gr deleted the feat/aws-security-tags branch October 2, 2023 08:57
@elasticmachine
Copy link

Package aws - 2.7.0 containing this change is available at https://epr.elastic.co/search?package=aws

3 similar comments
@elasticmachine
Copy link

Package aws - 2.7.0 containing this change is available at https://epr.elastic.co/search?package=aws

@elasticmachine
Copy link

Package aws - 2.7.0 containing this change is available at https://epr.elastic.co/search?package=aws

@elasticmachine
Copy link

Package aws - 2.7.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

Assignees
No one assigned
Labels
enhancement New feature or request Integration:AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marc-gr @elasticmachine @kaiyan-sheng @kcreddy @tommyers-elastic