Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add data_stream.dataset filter in dashboards across all the integrations that have it missing. #9323

Open
2 of 55 tasks
lalit-satapathy opened this issue Mar 11, 2024 · 8 comments
Assignees

Comments

@lalit-satapathy
Copy link
Collaborator

lalit-satapathy commented Mar 11, 2024

As part of this task, need to add the data_stream.dataset filter across all the integrations.

Following integration will be covered as part of this
As part of this #8751 work will be completed as well.
This issue will cover the integration those has owner obs-infraobs-integrations

Completed:

In Review:

In Progress:

  • Awsfargate
  • azure_app_service
  • azure_application_insights
  • azure_billing
  • azure_functions
  • Etcd
  • Haproxy
  • Ibmmq
  • jolokia_input
  • Kafka
  • kafka_log
  • microsoft_sqlserver
  • Mongodb
  • mongodb_atlas
  • Mysql
  • nagios_xi
  • Nginx
  • Oracle_weblogic
  • php_fpm
  • Postgresql
  • Prometheus
  • prometheus_input
  • Rabbitmq
  • Redis
  • Redisenterprise
  • Salesforce
  • Springboot
  • sql_input
  • stasd_input
  • Tomcat
  • Trafik
  • vsphere
  • websphere_application_server
@lalit-satapathy
Copy link
Collaborator Author

@milan-elastic, Lets target this for next sprint. Please update the description with details.

Looks overlap of: #8751

@milan-elastic
Copy link
Contributor

@milan-elastic, Lets target this for next sprint. Please update the description with details.

Looks overlap of: #8751

Sure! @lalit-satapathy

@lalit-satapathy
Copy link
Collaborator Author

Another duplicate: #7400

@lalit-satapathy
Copy link
Collaborator Author

Duplicate: #7217

@milan-elastic
Copy link
Contributor

For the data_stream.dataset filter, I have found the couple of scenarios as mentioned below,

  • There would be some dashboards where event.dataset is present instead of data_stream.dataaset so we will update that filter from event.dataset to data_stream.dataset
  • If the dashboard contains the multiple data stream fields, we will add the data stream filters with OR operator,
    For example, if the dashboard is having session and memory data stream fields we will add e.g. data_stream.dataset: apache_tomcat.session OR data_stream.dataset: apache_tomcat.memory

From a PR perspective, we will structure our PRs as follows, categorizing them into the following groups of packages:
- AWS
- Azure
- GCP
- Cloud Native packages
- Infra-Obs packages

If the PRs are too big, we'll divide them further.
CC: @lalit-satapathy @tommyers-elastic

@shmsr
Copy link
Member

shmsr commented Apr 8, 2024

Duplicate #8348?

@ishleenk17
Copy link
Contributor

ishleenk17 commented Apr 12, 2024

  • There would be some dashboards where event.dataset is present instead of data_stream.dataset so we will update that filter from event.dataset to data_stream.dataset

Are the event.dataset and data_stream.dataset values always the same? To confirm that it doesn't break dashboards for existing users.

@milan-elastic
Copy link
Contributor

  • There would be some dashboards where event.dataset is present instead of data_stream.dataset so we will update that filter from event.dataset to data_stream.dataset

Are the event.dataset and data_stream.dataset values always the same? To confirm that it doesn't break dashboards for existing users.

So far we have noticed that it has the same values, but if we see if it's different I'll mention that explicitly in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants