Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global level data_stream.daataset dashboard filter #9768

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented May 1, 2024

Proposed commit message

Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.

Expect the above mentioned changes done in following selected packages to ease the review

  • ActiveMQ
  • Apache Spark
  • Apache Tomcat
  • Hadoop
  • Airflow
  • Apache
  • Cassandra
  • Ceph
  • Citrix Adc
  • CockroachDB

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshot

ActiveMQ
Broker Before Broker After
activemq  broker - before activemq broker - after
Topic Before Topic After
activemq  topic - before activemq  topic - after
Logs Before Logs After
activemq  logs - before activemq  logs - after
Queue Before Queue After
ActiveMQ  Queue - before activemq  queue - after
Audit Before Audit After
activemq  audit - before activemq  audit - after
Apache Spark
Overview Before Overview After
apache spark  overview - before apache spark  overview - after
Apache Tomcat
Session Before Session After
apache tomcat  session - before apache tomcat  session - after
Metrics Overview Before Metrics Overview After
apache tomcat  metrics overview - before apache tomcat  metrics overview - after
Before After
apache tomcat  rquest - before apache tomcat  request - after
Memory Before Memory After
apache tomcat  memory - before apache tomcat  memory - after
Cache Before Cache After
apache tomcat  cache - before apache tomcat  cache - after
Threadpool Before Threadpool After
apache tomcat  thread pool - before apache tomcat  thread pool - after
Connection pool Before Connection pool After
apache tomcat  connection pool - before apache tomcat  connection pool -after
Hadoop
Datanode Before Datanode After
before_hadoop_datanode after_hadoop_datanode
Node Manager Before Node Manager After
before_hadoop_node_manager after_hadoop_node_manager
Cluster Before Cluster After
before_hadoop_cluster after_hadoop_cluster
Application Before Application After
before_hadoop_application after_hadoop_application
Airflow
stasd Before stasd After
before_airflow_statsd after_airflow_statsd
Apache
Status Before Status After
before_apache_status after_apache_status
Logs Before Logs After
before-apache-logs-overview after-apache-logs-overview
Cassandra
Before After
cassandra  metrics overview - before cassandra  metrics overview - after
Cassandra Before Cassandra After
cassandra  system logs - after cassandra  system logs - before

|

Ceph
Ceph Before Ceph After
ceph  overview -before ceph  overview -after
Citrix ADC
lbvserver Before lbvserver After
citrix adc  lbvserver - before citrix adc  lbvserver - after
system Before system After
citrix adc  system - before citrix adc  system - after
service Before service After
citrix adc  service - before citrix adc  service - after
vpn Before vpn After
citrix adc  vpn - before citrix adc  vpn - after
interface Before interface After
citrix adc  interface - before citrix adc  interface - after
metrics overview Before metrics overview After
citrix adc  metrics overview - before citrix adc  metrics overview - after
CockroachDB
CockroachDB Before CockroachDB After
cockroachdb  metrics overview - before cockroachdb  metrics overview - after

@elasticmachine
Copy link

elasticmachine commented May 1, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@milan-elastic milan-elastic self-assigned this May 9, 2024
@milan-elastic milan-elastic marked this pull request as ready for review May 9, 2024 07:54
@milan-elastic milan-elastic requested a review from a team as a code owner May 9, 2024 07:54
@agithomas
Copy link
Contributor

agithomas commented May 14, 2024

Shouldn't the images of the dashboard be updated?

@agithomas
Copy link
Contributor

Any reason why this change is considered an enhancement, not a bugfix?

@milan-elastic
Copy link
Contributor Author

Any reason why this change is considered an enhancement, not a bugfix?

Adding filters would improve the performance of the dashboard. Currently, many integrations are working fine without dashboard-level filters and are not experiencing any issues. However, implementing filters at the dashboard level will enhance dashboard loading efficiency. Therefore, I am categorizing this as an enhancement rather than a bug fix.

@milan-elastic
Copy link
Contributor Author

Shouldn't the images of the dashboard be updated?

Yes, ideally it should be updated, but populating the dashboard with data that looks attractive for each package mentioned here would be a significant effort. From a visualization perspective, we are not making any changes; we are only adding a top-level filter. Therefore, I believe we shouldn't undertake this effort just to show the filter in the screenshot. Whenever there is a change in visualization, that person can update the screenshot accordingly.

@harnish-elastic harnish-elastic self-requested a review May 15, 2024 06:17
@elasticmachine
Copy link

elasticmachine commented May 23, 2024

💔 Build Failed

Failed CI Steps

History

cc @milan-elastic

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants