Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[okta] Add system tests #1034

Merged
merged 2 commits into from
Jun 8, 2021
Merged

[okta] Add system tests #1034

merged 2 commits into from
Jun 8, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 31, 2021

What does this PR do?

  • Adds httpjson system tests for okta package
  • Remove log input which only purpose was to have system tests

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 31, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1034 updated

  • Start Time: 2021-06-08T09:21:40.385+0000

  • Duration: 14 min 23 sec

  • Commit: 54a36bb

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I presume no one would use the logfile input either way here.

- --start-signal=SIGHUP
- --addr=:8080
- --http-server-response-headers="Link"
- --http-server-response-headers="next=http://elastic-package-service_okta_1/api/v1/logs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the new "profile" feature of elastic-package creates an issue here for the hostname. My guess is that it uses a custom docker-compose project name which would break the hardcoded name.

If stream could do a substitution where it reflects back the same hostname used in the HTTP request then that would be more portable. Or if it could substitute in an env var that would work too since it could return the container ID which should be resolvable to the client. For example:

--http-server-response-headers="next=http://{{ RequestAddr }}/api/v1/logs"

--http-server-response-headers="next=http://{{ env 'HOSTNAME' }}/api/v1/logs"

@marc-gr
Copy link
Contributor Author

marc-gr commented Jun 8, 2021

/test

@marc-gr marc-gr merged commit 1d86053 into elastic:master Jun 8, 2021
@marc-gr marc-gr deleted the okta_system branch June 8, 2021 09:38
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
* Add system tests

* Use new mock server
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add system tests

* Use new mock server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants