-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[okta] Add system tests #1034
[okta] Add system tests #1034
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I presume no one would use the logfile input either way here.
- --start-signal=SIGHUP | ||
- --addr=:8080 | ||
- --http-server-response-headers="Link" | ||
- --http-server-response-headers="next=http://elastic-package-service_okta_1/api/v1/logs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the new "profile" feature of elastic-package creates an issue here for the hostname. My guess is that it uses a custom docker-compose project name which would break the hardcoded name.
If stream
could do a substitution where it reflects back the same hostname used in the HTTP request then that would be more portable. Or if it could substitute in an env var that would work too since it could return the container ID which should be resolvable to the client. For example:
--http-server-response-headers="next=http://{{ RequestAddr }}/api/v1/logs"
--http-server-response-headers="next=http://{{ env 'HOSTNAME' }}/api/v1/logs"
/test |
* Add system tests * Use new mock server
* Add system tests * Use new mock server
What does this PR do?
Checklist
changelog.yml
file.- [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Related issues
v0.5.0