[fortinet] Make event.original optional in fortinet #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
marc-gr
force-pushed
the
fortinet-eventoriginal
branch
2 times, most recently
from
5dd8a19
to
707d74d
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
marc-gr
force-pushed
the
fortinet-eventoriginal
branch
from
707d74d
to
4ca5622
Compare
43 tasks
P1llus
approved these changes
Jun 3, 2021
| {{#if internal_interfaces.length}} | ||
| {{else}} | ||
| {{#if external_interfaces.length}} | ||
| processors: |
There was a problem hiding this comment.
Is processors meant to be twice here?
| {{#if internal_interfaces.length}} | ||
| {{else}} | ||
| {{#if external_interfaces.length}} | ||
| processors: |
There was a problem hiding this comment.
Is processors meant to be twice here?
There was a problem hiding this comment.
It is added only once, in case any of internal_interfaces and external_interfaces are set, otherwise processors can be empty and it was breaking the system tests. This if else if is needed since handlebars lacks an || operator.
james-elastic
pushed a commit
to james-elastic/integrations
that referenced
this pull request
Jun 30, 2021
26 tasks
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes event.original optional
Checklist
changelog.ymlfile.- [] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).Related issues
Screenshots